Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[graphics] Do eyes on the GPU, fix filtering and offsets #1219

Merged
merged 1 commit into from
Mar 4, 2022
Merged

[graphics] Do eyes on the GPU, fix filtering and offsets #1219

merged 1 commit into from
Mar 4, 2022

Conversation

water111
Copy link
Collaborator

@water111 water111 commented Mar 4, 2022

There are lots of advantages to doing eyes on the GPU:

  • lets us increase the texture size (default is 128x128 now)
  • filtering + blending works (unlike my CPU version, which didn't work right when doing both on the pupils)
  • the slight offset bug is gone (I guess I don't fully understand how filtered textures work along the edges?)
  • we now use the full precision of the animation. The old version had a bug where the lower 4 bits were lost.

@water111 water111 merged commit 7c3ab1f into master Mar 4, 2022
@water111 water111 deleted the w/rounder-eyes branch March 4, 2022 23:22
This was referenced Mar 4, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@water111